I learnt today that Clippy doesn't report error/warnings after cargo check, which meant that the GitHub Action I had defined was ineffective. I've introduced a cargo clean step to ensure the build will fail if we don't keep clippy happy.
In my most recent PR I standardised on the form Err(...)?; but clippy doesn't recommend this so I've gone back to the return form in all cases.
In addition, I'm adding a check to make sure that code is formatted according to rustfmt. In my experience this is useful to avoid needless merge conflicts (and arguments), and we can rely on the "skip" macro if there's anything that really deserves to have its whitespace left intact.
I learnt today that Clippy doesn't report error/warnings after cargo check, which meant that the GitHub Action I had defined was ineffective. I've introduced a
cargo cleanstep to ensure the build will fail if we don't keep clippy happy.In my most recent PR I standardised on the form
Err(...)?;but clippy doesn't recommend this so I've gone back to thereturnform in all cases.In addition, I'm adding a check to make sure that code is formatted according to
rustfmt. In my experience this is useful to avoid needless merge conflicts (and arguments), and we can rely on the "skip" macro if there's anything that really deserves to have its whitespace left intact.