search

thombruce / toodles

✅ A super simple todo app
https://toodles.thombruce.com/
GNU General Public License v3.0
0 stars 0 forks source link

[Bug]: Address failing CI job #132

Closed thombruce closed 2 months ago

thombruce commented 2 months ago

What happened?

The failing CI job is for tests which exist on the old web implementation of Toodles (now redundant).

I don't think there's any good reason to fix these tests (I'm not even sure why they're broken - did I make a change I shouldn't have?).

A temporary solution would be to disable the CI testing altogether, as the tests are no longer relevant to us going forwards.

Obviously a better solution would be to write new tests for the code that is relevant.

We can do one, the other or one then the other. Doesn't matter. Just address the fact that CI is failing where said failing isn't actually relevant.

I believe the task that's run is something like lerna run test which will run a "test" script for all packages which have one. So we could simply remove this script from the old web implementation first of all... and that's probably the most straightforward solution - those tests aren't relevant anyway, and the package directory will eventually be scrapped entirely.

Version

0.0.1 (Default)

What browsers are you seeing the problem on?

No response

Relevant log output

No response

Code of Conduct

thombruce commented 2 months ago

This removes the test scripts from the old app: 86e98f2e57bf09d4ed33f48d06574512ec80e2ad

Not sure if it resolves the failing tests (with no tests/coverage to run, might the CI task still fail in their absence? perhaps because of lack of coverage?) but if we're green I'll close this. If not... second commit incoming.

thombruce commented 2 months ago

So yeah, here's that second commit: 253c934ded0141c73399f9951e53131161a56726

...because we also did have to disable the coverage action.