search

thombruce / toodles

✅ A super simple todo app
https://toodles.thombruce.com/
GNU General Public License v3.0
0 stars 0 forks source link

PWA #91

Closed thombruce closed 1 year ago

thombruce commented 1 year ago

closes #89

netlify[bot] commented 1 year ago

Deploy Preview for toodles ready!

Name Link
Latest commit 6a8def322c471381dca5f549decbc59533c96ed1
Latest deploy log https://app.netlify.com/sites/toodles/deploys/649e331030cbc50008aa9f56
Deploy Preview https://deploy-preview-91--toodles.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

Coverage Summary for `./packages/web`

Status Category Percentage Covered / Total
🟢 Lines 67.07% / 60% 379 / 565
🟢 Statements 67.07% / 60% 379 / 565
🟢 Functions 65.9% / 60% 29 / 44
🟢 Branches 71.42% / 60% 45 / 63
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
packages/web/src/components/ContextTag.vue 20% 100% 0% 20% 4-15
packages/web/src/components/HashTag.vue 20% 100% 0% 20% 4-15
packages/web/src/components/ProgressBar.vue 70.58% 75% 100% 70.58% 8-10, 13-19
packages/web/src/components/ProjectTag.vue 20% 100% 0% 20% 4-15
packages/web/src/components/TagTag.vue 71.42% 100% 0% 71.42% 6-7
packages/web/src/components/TodoItem.vue 77.35% 40% 28.57% 77.35% 20-23, 26, 31-37
packages/web/src/components/TodoList.vue 73.68% 100% 100% 73.68% 11-15
packages/web/src/components/TodoPriority.vue 20% 100% 0% 20% 4-15
packages/web/src/components/TodoText.vue 61.7% 57.14% 85.71% 61.7% 15-18, 21-25, 30, 33-36, 39-42
packages/web/src/models/Todo.ts 87.65% 75% 88.88% 87.65% 27-32, 46-47, 63-64
packages/web/src/plugins/dexie.ts 50% 100% 66.66% 50% 25-31, 35-54
packages/web/src/plugins/lunr.ts 100% 100% 100% 100%
packages/web/src/plugins/timepiece.ts 71.42% 60% 50% 71.42% 14-19
packages/web/src/stores/todos.ts 72.57% 90% 83.33% 72.57% 21, 25, 29-31, 35-37, 41-43, 47-49, 53-55, 59-61, 65-67, 71-73, 77-79, 83-85, 89-91, 95-97, 103, 107-115
thombruce commented 1 year ago

General PWA issues reported by Lighthouse for the Netlify preview build:

image

image

thombruce commented 1 year ago

Vite PWA Plugin has this page describing some of the minimal requirements and how to meet them: https://vite-pwa-org.netlify.app/guide/pwa-minimal-requirements.html

thombruce commented 1 year ago

PWA support is now all green in Lighthouse:

image

thombruce commented 1 year ago

What does this achieve?

In theory, it means the web app is installable from the browser wherever that is supported.

This should enable the app to run offline. It will store data in its own browser instance (not sure if this is shared with the version still on a webpage... probably?).

What else?

It opens up the capability to introduce a service worker in the future that would sync offline activity with a cloud server... even if only in the sense that it yields offline capability at this point. This is still a complex matter, requiring different solutions in different environments.

thombruce commented 1 year ago

Added robots.txt at recommendation of https://vite-pwa-org.netlify.app/guide/pwa-minimal-requirements.html#search-engines

Otherwise... we don't need a service worker to be fully implemented at this time, so we can skip that and revisit it in the future.

This is ready to merge.