Game Over - Githubissues

thombruce / verse

🚀 A universe in progress

Other

8 stars 0 forks source link

Game Over #103

Closed thombruce closed 9 months ago

thombruce commented 9 months ago

closes #59

By submitting this pull request, you agree to follow our Code of Conduct: https://github.com/thombruce/.github/blob/main/CODE_OF_CONDUCT.md

Internal use. Do not delete.

[x] Tests passing
[x] Coverage sufficient
[x] Manual review
[x] No A11y regression
[x] Translations provided or not needed

thombruce commented 9 months ago

Issues

[x] With the exception of the physics system, all other active game systems pause[^1]

[^1]: This isn't a massive problem, but I would prefer for things like animation and UI elements to continue operating in part to show that the universe goes on without you in it, and in part because we'll eventually need these systems to continue working outside of the main active state in any case (e.g. when we add interior view(s) and other gameplay states).

thombruce commented 9 months ago

More Issues

[x] Menu is unresponsive initially
[x] "Enter" press can result in new game as soon as player quits

thombruce commented 9 months ago

"Enter" press just isn't working very well at all... Adding a second button has helped the menu, but it still isn't initially responding sometimes.

Navigating between focusables is working just fine. It is as if the actionable button press system just isn't running...

thombruce commented 9 months ago

...and I know exactly why.

thombruce commented 9 months ago

Basically, I had introduced a conflict between two systems each fighting to command the next_state. The GameOver next_state handling was still running every frame in the absence of the player...

This would probably be better handled by a single event and a one off system, but I'm going to deliver as is and leave that for future refactoring (the one off systems are a new feature in Bevy 0.12 and I haven't played with them yet; not sure how stable or experimental they still are).