search

thomcc / arcstr

Better reference counted strings for Rust
Apache License 2.0
114 stars 18 forks source link

Add Zlib as a license option so that binary distributions aren't required to bundle our license text #19

Closed thomcc closed 4 years ago

thomcc commented 4 years ago

@rodrimati1992 You didn't actually write any of the code here, but I added you as a coauthor of one of the commits because you came up with the idea that arcstr uses to make the arcstr::literal! macro viable.

This was mostly a courtesy, but because you're listed as a co-author of one of the commits, it seems negligent to change this without your sign-off.

So, please add a comment to this issue indicating your approval of switching to tri-license ZLIB/MIT/APACHE-2.0, thanks.

codecov-commenter commented 4 years ago

Codecov Report

Merging #19 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   97.21%   97.21%           
=======================================
  Files           6        6           
  Lines         861      861           
=======================================
  Hits          837      837           
  Misses         24       24

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 537c1c4...02db1c2. Read the comment docs.

rodrimati1992 commented 4 years ago

I approve the switch to tri-license ZLIB/MIT/APACHE-2.0