search

thomersch / openstreetmap-calendar

osmcal, a Collaborative Calendar for OpenStreetMap-related Events
https://osmcal.org
Apache License 2.0
33 stars 9 forks source link

Use preferred tile.openstreetmap.org URL #146

Open danieldegroot2 opened 8 months ago

danieldegroot2 commented 8 months ago

I would like to suggest using the now preferred https://tile.openstreetmap.org URL instead of the current ones (a, b, c, etc.), see

https://github.com/openstreetmap/operations/issues/737

LaoshuBaby commented 2 months ago

Search in VSCode

I would like to suggest using the now preferred https://tile.openstreetmap.org URL instead of the current ones (a, b, c, etc.), see

openstreetmap/operations#737

I've searched and found no URL are using tiles from OSM, neither unified or a/b/c, could you point out where those kind of codes located? Thank you.

thomersch commented 2 months ago

They're coming from the django-leaflet library. It would probably make sense to upgrade this dependency, but I haven't checked whether they have changed the default to the non-abc domain. Also: OSMCAL has some glue code that controls the leaflet integration (for the create/edit event form), which needs to be tested to verify that the upgrade doesn't break anything.

There is probably some option to override the default tile layer, but I haven't looked that up.

LaoshuBaby commented 2 months ago

They're coming from the django-leaflet library. It would probably make sense to upgrade this dependency, but I haven't checked whether they have changed the default to the non-abc domain.

Yes, it's from this library and I've checked they haven't make such kind of change. So I open this https://github.com/makinacorpus/django-leaflet/pull/375 PR just now