search

thomersch / openstreetmap-calendar

osmcal, a Collaborative Calendar for OpenStreetMap-related Events
https://osmcal.org
Apache License 2.0
33 stars 9 forks source link

Feature/pre set time #40

Closed ghost closed 4 years ago

ghost commented 4 years ago

Fix issue with duplicating the start time -- it make sense to copy the start date/time, becuase the date will be changed anyway but the time don't have to be. (So there is few clicks less when start date/time copied compared to not copied.)

thomersch commented 4 years ago

Thanks! This copies the start date as well, which we didn't really want. I am afraid that user could submit the old date by mistake, which I would like to prevent.

About that reformatting: I am willing to reformat the code using some standard tool like black, but let's do this as a separated effort. There are branches I am working on and such changes of almost every line make it unnecessarily difficult to merge afterwards.

ghost commented 4 years ago

About that reformatting: I am willing to reformat the code using some standard tool like black, but let's do this as a separated effort. There are branches I am working on and such changes of almost every line make it unnecessarily difficult to merge afterwards.

Would you mind to prioritize this? For me, it's currently paint to read the code :(

ghost commented 4 years ago

I use today's date and original time when duplicating event. Is this approach ok for you?

ghost commented 4 years ago

Hi @thomersch, this is week bump :)

thomersch commented 4 years ago

Sorry for the delay, I am extra busy at the moment. Please gimme until end of week :)