search

thomjur / PyCollocation

Python module to do simple collocation analysis of a corpus.
GNU General Public License v3.0
0 stars 1 forks source link

Update test.py #10

Closed trutzig89182 closed 2 years ago

trutzig89182 commented 2 years ago

Changed test.py to unittest structure. Related to #2

trutzig89182 commented 2 years ago

If I saw it correctly, our simultaneous approaches are essentially identical. Perhaps just have a swift look at it, if there is something that could still be interesting, and just delete the pull request otherwise. @thomjur

thomjur commented 2 years ago

Yes, it is pretty much the same. I am unsure whether the collection really belongs in a setUp here... and I also agree that we should delete the display function. So if you want you can merge this one. Only thing are the comments, I think it would be better to write them Multiline within the function.

trutzig89182 commented 2 years ago

Why do you think its better to write them multiline? I am ok with it anyway, just out of curiosity.

I will close this pull request and then continue to work on your version.