thomki / ro-rail

Automatically exported from code.google.com/p/ro-rail
0 stars 0 forks source link

update tag autoflagging to false? #50

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Include rail_state["update"] = true in your state file
2. Call/summon Homunculus or invoke RAIL
3. Check State file, rail_state["update"] now becomes = false

What is the expected outcome? What do you see instead?
I would expect that 'true' remains true, unless I misunderstand the purpose of 
this hidden tag.

What revision of the product are you using?
r194

What type of homunculus/mercenary are you using?
Vanil

Please provide any additional information below.
Just a bit odd; pyRO-RAIL hard codes this value to 'true' every time it outputs 
the value (for now). Whenever the AI is invoked, it toggles to false.

Original issue reported on code.google.com by landstei...@gmail.com on 9 Dec 2010 at 8:41

GoogleCodeExporter commented 8 years ago
This is by design.

The update option is meant to specify that changes have been made and the AI 
should reload the state-file. Once the new options have been loaded, there is 
no reason to continue updating until there are more changes.

pyRO-RAIL *should* hard-code the value to `true` every time. This causes any 
changes made by pyRO-RAIL to take effect immediately, and it does not require a 
Rest/Call or relog. You'll notice that even without rest/call, RAIL changes 
"update" to false as soon as it has loaded the file.

Since loading takes precedence saving, if RAIL did not change "update" to 
false, it would lose certain changes it makes as it uses the state-file. For 
example, when RAIL uses a buff (flitting, for example) it records the time that 
flitting should be used again. If continually RAIL reloads the state-file, then 
RAIL has no way of saving this new value and it will attempt to recast flitting 
at a time that is much too early.

Original comment by faithful...@gmail.com on 9 Dec 2010 at 9:25

GoogleCodeExporter commented 8 years ago
Thanks for the clarification. I'll keep the hard-coded 'true' value then.

Original comment by landstei...@gmail.com on 9 Dec 2010 at 9:30