thomluther / ha-anker-solix

Home Assistant integration for Anker Solix Power devices
MIT License
198 stars 5 forks source link

Decrease minimum home preset to 10W #108

Closed andythomas closed 1 month ago

andythomas commented 1 month ago

This solves #107

thomluther commented 1 month ago

Thanks for the suggested changes, but cannot change the constants for the minimums since this may break SB1 usage. I fixed it in the validators for the services, which are defined in the const.py

VALID_APPLIANCE_LOAD = vol.Any(
    None,
    cv.ENTITY_MATCH_NONE,
    vol.All(
        vol.Coerce(int),
        vol.Range(
            #min=api.SolixDefaults.PRESET_MIN,  # Min for SB1 usable only
            min=0,
            max=api.SolixDefaults.PRESET_MAX * 2,
        ),
    ),
)

I also assume 0 W is the minimum that can be applied in the schedule, or is this really 10W? This would not allow to stop export for an interval???

andythomas commented 1 month ago

I did not want to confuse you with the 10W. I just looked at it from my personal use-case perspective. I have a base load of 95W and, therefore, have only one schedule 24/7 of a constant value. If it is 100W, I feed just a little bit into the grid at night, which I want to avoid. Consequently, I use 90W, 50W or whatever value will turn out to match my installation. Just 0W makes no sense for me, because I would basically not utilize the battery in its intended way. Certainly, other people might want 0W at certain times.

I tested the new version and it works nicely. It might be intentional, but the version number showing in the integration was not bumped.

Thank you for all the work!

thomluther commented 1 month ago

@andythomas thanks for confirming. I did not bump the version because I need more feedback if all the schedule changes work with the SB2 since I cannot test it. Please have a look to https://github.com/thomluther/hacs-anker-solix/discussions/105#discussioncomment-10290014 and confirm any of those test cases if you are able to run them

Once no more fixes are required, I can cut the final release 2.1.0 for the SB2 home load and schedule services support. For the time being, I only commit new changes to main branch and it use that, you either have to download and install it manually, or use the update service against the 'main' version.