thompson-vii / kb16_rev2_vial_fw

compiled firmware for doio's kb16 rev2 (aka megalodon trip knob macropad)
66 stars 25 forks source link

Fix array lengths, use QMK ARRAY_SIZE macro #8

Closed bclarke123 closed 1 year ago

bclarke123 commented 1 year ago

This PR fixes the way oled_write_raw_P is called, currently the array sizes for logo and layer are set to 525 instead of 512, causing erroneous data to get written to the OLED buffer as far as I can tell. Uses ARRAY_SIZE, which was added to QMK in August and hasn't been ported to Vial QMK, so definitions are included as part of this PR in util.h. Tested on my rev2 KB16, appears to give back 200 bytes or so in firmware size.

Thanks for this keymap, I hope this is helpful!

NicholasYamamoto commented 1 year ago

Paging @thompson-vii