search

thompsonate / Shifty

☀️ A macOS menu bar app that gives you more control over Night Shift.
http://shifty.natethompson.io
GNU General Public License v3.0
1.25k stars 33 forks source link

Improved Dark Mode Toggle functionality #100

Closed JakobFelixJulius closed 3 years ago

JakobFelixJulius commented 4 years ago

Hello! Great project, been using it for quite some time. I added some improved Dark Mode functionality because this was missing for me and this now gives me improved usability.

  1. New menu bar entry "Toggle Dark Mode" to switch easily between dark/light mode. I didn't feel the need to add state to this entry (e.g. contextual "Turn on..." and "Turn off..." as it is with the Night Shift menu bar entry) because the Dark Mode is clearly visible on the OS. Also added proper localization.

  2. Added functionality to the Quick Toggle: when activated, Shift-clicking the menu bar icon toggles Dark Mode. Added description to the preferences entry to reflect this change with proper localization.

  3. Changed the .leftMouseUp event listener to leftMouseDown, worked much more reliable on my MacBook Pro trackpad.

Overall just small changes, but this improved the app for me a lot and I thought I might share it with everyone, in case you find this useful too!

Tested with macOS Catalina 10.15.4

Screen Shot 2020-05-27 at 13 44 14

thompsonate commented 3 years ago

Hi there, sorry I completely missed this PR!

I'm glad this works well for you, but I'm not convinced that Shifty needs to take on more Dark Mode features. Shifty doesn't get much development attention as it is, and I'm worried that feature creep would be detrimental in the long run. There are plenty of other menu bar apps that exist to toggle Dark Mode, and I think it's best to keep Shifty focused on Night Shift.