Doesn't turn on automatically, and doesn't disable for disabled apps

[jeff-h]

Basically the app does nothing for me! I have the schedule set to "Sunset to Sunrise" yet Night Shift does not come on at sunset. I can turn it on manually using Shifty, but then it fails to disable for any apps I set as "Disabled". "Disabled for an hour" does work.

I'm happy to build and debug a little but are you aware of anything that might cause the behaviour I'm seeing, or anywhere in particular I should start looking?

[jeff-h]

I've read through the code and think perhaps I am just misunderstanding how this is supposed to work.

I'm trying to:

• turn on "Turn on Night Shift" manually via the Shifty menu
• Night Shift does come on, as expected, even though it's currently daytime.
• select "Disable for XYZ"
• I would expect night shift to turn off but it doesn't.

Tracing this through the code, flow never goes inside the (rather frightening) logic here: https://github.com/thompsonate/Shifty/blob/master/Shifty/StatusMenuController.swift#L676-L679

...because isShiftForAppEnabled is set to false here: https://github.com/thompsonate/Shifty/blob/master/Shifty/StatusMenuController.swift#L578

...because scheduledState is false.

I've read through https://github.com/thompsonate/Shifty/blob/master/Shifty/StatusMenuController.swift#L218-L234 and come to the conclusion that it will never turn off night shift for a specific app if it's daytime, even if night shift is turned on via the "Turn on night shift".

Sorry if the above is all too verbose and hard to follow. Basically, I think if it's daytime, Shifty does not disable Night Shift for chosen apps even if Night Shift is on because I choose "Turn on Night Shift".

[thompsonate]

Thanks for looking into this and providing steps to reproduce. You're right, its a bug and my logic is rather frightening. I'm working on completely refactoring the core logic (even though I haven't touched it in a month). I'll get a version 1.0 out eventually and make sure it doesn't have this issue.

[jeff-h]

Thanks! Sorry I called it frightening — I rather meant it frightened me :) I suspect the logic simply isn't straightforward. Regardless, glad you've time to look into it — the app is really neat and I'd really like to use it!