search

thompsonate / Shifty

☀️ A macOS menu bar app that gives you more control over Night Shift.
http://shifty.natethompson.io
GNU General Public License v3.0
1.24k stars 33 forks source link

Shifty fails to detect active website during full screen video in Safari #98

Open momenabdelkarim opened 4 years ago

momenabdelkarim commented 4 years ago

Disabling Night Shift for a website on Safari doesn't work if you're playing a video in full screen. I tested this on Youtube and Netflix. It works on Chrome though.

To reproduce:

  1. Open Safari
  2. Open any Youtube video
  3. In Shifty menu, disable Night Shift "for YouTube.com". Night Shift should turn off now.
  4. Enter full screen for the video. Night Shift is automatically re-enabled. If you open the Shifty menu you'll notice Shifty stops recognizing which website you're on in Safari.
choco commented 4 years ago

I have this fixed in my own branch. You can use the build in this comment if you'd like https://github.com/thompsonate/Shifty/issues/90#issuecomment-541559220 and let me know how it goes for you (it also includes some optimizations specifically for Safari). I would really want to find time to clean up and push a PR but I've been super busy.

zdlo commented 2 years ago

Is choco's branch still the only way to make fullscreen Safari work with Shifty, after two years?