search

thomthom / SKUI

Ruby wrapper of classes that maps to GUI controls in SketchUp's UI::WebDialogs
MIT License
26 stars 14 forks source link

Remove SKUI from top-level scope? #70

Closed jimfoltz closed 10 years ago

jimfoltz commented 10 years ago

Is this line supposed to remove the SKUI from the top-level scope? Is it working? I notice SKUI is still defined top-level after embedding.

https://github.com/thomthom/SKUI/blob/master/src/SKUI/embed_skui.rb#L33

On a whim, I wrapped the line in a start_timer block and then SKUI was no longer available top-level. Maybe a constant can not be removed from within its own scope?

thomthom commented 10 years ago

SKUI.embed still remails, but evertthing else is scoped in the module it's embedded in. Just check the methods of the module to confirm.

Sent from my Sony Xperia™ smartphone

Jim Foltz notifications@github.com wrote:

Is this line supposed to remove the SKUI from the top-level scope? Is it working? I notice SKUI is still defined after after embedding.

https://github.com/thomthom/SKUI/blob/master/src/SKUI/embed_skui.rb#L33

On a whim, I wrapped the line in a start_time block and then SKUI was no longer available top-level. Maybe a constant can not be removed from within its own scope?

— Reply to this email directly or view it on GitHub.

jimfoltz commented 10 years ago

I see.

SKUI.methods(false)
[embed_in]
thomthom commented 10 years ago

It ensures that SKUI can be used side by side as a dependency.

Sent from my Sony Xperia™ smartphone

Jim Foltz notifications@github.com wrote:

I see.

SKUI.methods(false) [embed_in]

— Reply to this email directly or view it on GitHub.