thomthom / quadface-tools

Suite of tools for manipulating quad faces in SketchUp.
https://extensions.sketchup.com/en/content/quadface-tools
MIT License
18 stars 1 forks source link

The toolbar icons look too small in a 4K monitor #131

Closed alsomar closed 3 years ago

alsomar commented 3 years ago

Maybe .svg icons (instead png) could fix this.

thomthom commented 3 years ago

Yea, it would. Long time ago I began to work on SVG (and PDF for mac), https://github.com/thomthom/quadface-tools/tree/dev-vector-icons

But I've fallen short of time. There's a lot of icons!

thomthom commented 3 years ago

Maybe I could make a call for assistance to the community... 🤔

alsomar commented 3 years ago

Is there any guidelines or any specific detail to know for creating those icons? If so, I could vectorize them!

thomthom commented 3 years ago

I got a bunch done, but more is needed: https://github.com/thomthom/quadface-tools/tree/dev-vector-icons/Resources/Icons

Give a few days to see if I can setup a way to use this WIP so it's possible to view the SVG icons in SU. Then dig up my notes on technical requirements for them to work.

Somewhere I have a script that can convert SVG to PDF, so we don't really need to worry about the PDF versions.

alsomar commented 3 years ago

Hello again, I've remade the entire toolset. Hope it helps: QFT_SVG.zip

thomthom commented 3 years ago

Wow!

That's amazing!

I need to make some adjustments to ensure they match the pixel grid. On a "normal" DPI monitor lines get blurry:

image

Looks like the stoke sizes are slightly larger than 1px.

image

What software did you use to edit? I'm not sure if Inkspace is displaying the SVGs entirely correctly.

alsomar commented 3 years ago

Oops, I think I used points (pt) instead of pixels (px), I guess that's why there's some strange sizes. I did it on Affinity Designer, a cheap alternative to Adobe Illustrator. I'll try to fix the sizes this weekend

alsomar commented 3 years ago

Hi there again. I've fixed the icons, now they should work fine PS I've just updated the file, I found a couple of errors QFT_SVG_210619-1106.zip (updated)

thomthom commented 3 years ago

Sorry for slow response. Last week was hectic as I was finishing up things before my vacation started this weekend. Not sure if Iæll have time until I'm back from my trip next week.

alsomar commented 3 years ago

Don't worry and enjoy your well-deserved vacations!

thomthom commented 3 years ago

Ok, having a look at this again. For some reason several of the icons doesn't render properly. The SVG library SU uses is rather limited, so I assume the main issue is there. But it's a limitation we have.

image

It's strange how some of the icons render properly in either large or small variant, but not the other. I'll try to dig into what the difference might be.

Incidentally I'm seeing similar results using Microsoft PowerToys' SVG shell extension:

image

thomthom commented 3 years ago

Looking at the Connect icon there's something different:

image

The 24x24 icon got rounded corners. but I'm not able to adjust the corner style in this variant. I'm not sure why. (I don't use Inkspace that much.)

Another Inkspace thing I don't fully understand is the image size. When I don't have anything select it looks like this:

image

But to select the frame I need to double click a few times (assuming those are groups).

image

The image size is then different, and the line thickness is not 1.0 (even though it looks to be spot on.

thomthom commented 3 years ago

Hmm... the 24x24 don't actually have a stroke? It's a complex path instead?

Also, I really don't understand the Inkspace export settings:

image

I see 32x32 there under Export area, which makes sense because it's the size of the image. But what is "Image size" then?

alsomar commented 3 years ago

Hello there! I've been fixing the icons, getting stroke and fills into separate objets. I've also deleted the round corners, I guess it should work better now. By the way, in order to avoid confusion with native SketchUp tools I'm proposing a couple of changes in the Line and Select icons, let me know what you think. QFT_SVG_210716_1230.zip

thomthom commented 3 years ago

By the way, in order to avoid confusion with native SketchUp tools I'm proposing a couple of changes in the Line and Select icons, let me know what you think.

Yes, I like that. 👍

I'm seeing issues with the icons still:

image

Any ideas what the difference might be? I'm not able to pin down what triggers the black area. And the Explorer preview displays everything fine this time, so it's only in SU. (I really wish we'd update the SVG library.)

Btw, are you able to test the icons yourself? I can make a custom RBZ with the dev build that loads the SVG.

Also, there are two files that needs renaming:

WireframeToQuad_16.svg > WireframeToQuads_16.svg
WireframeToQuad_24.svg > WireframeToQuads_24.svg
alsomar commented 3 years ago

Any ideas what the difference might be? I'm not able to pin down what triggers the black area. And the Explorer preview displays everything fine this time, so it's only in SU. (I really wish we'd update the SVG library.)

I'm going to look into those svg files, let's see if I find something

Btw, are you able to test the icons yourself? I can make a custom RBZ with the dev build that loads the SVG.

It would be awesome, that way I wouldn't bother you as much as now!

Also, there are two files that needs renaming: WireframeToQuad_16.svg > WireframeToQuads_16.svg WireframeToQuad_24.svg > WireframeToQuads_24.svg

Ok!

thomthom commented 3 years ago

Here you go: (Rename the .zip to .rbz)

TT_QuadFaceTools-rename-to-rbz.zip

It would be awesome, that way I wouldn't bother you as much as now!

No bother at all! I'm very thankful and humbled that you take the time to work on these icons which I've procrastinated away for so long.

alsomar commented 3 years ago

There was some strange empty rectangles in some icons. Looks like that was the problem. Now they're looking good! Captura de pantalla 2021-07-16 14 53 57

I've checked them for both small and big size. Here they are: QFT_SVG_210716-1453.zip

alsomar commented 3 years ago

Aaaargh, there's a mistake in the smooth icon, let me fix it

alsomar commented 3 years ago

Ok, fixed. This should be the good one! QFT_SVG_210716-1714.zip

thomthom commented 3 years ago

Looking gooooood! :D

image

There are some lines that seems to fall of the pixel grid. I'm guessing those are not easy to see on a high-DPI monitor. I'll see if I can make some tweaks then batch generate PDFs.

thomthom commented 3 years ago

image

Got the 24x24 icons aligned to the pixel grid. :)

alsomar commented 3 years ago

Great, now they're looking perfect!

alsomar commented 3 years ago

Just for the record, I've just learned how to do that kind of visual adjustments with my software (affinity designer)

thomthom commented 3 years ago

Back to work this week. Not having a lot of spare computer time. If you want to have a run at the 16x16 then the latest dev build is attached.

TT_QuadFaceTools-RENAME-TO-RBZ.zip

alsomar commented 3 years ago

Hi there again! I just tested your last dev build on FHD monitor and it looks nice on both small and large size. Good job!

thomthom commented 3 years ago

16x16 icons on a low-DPI monitor also looks good! I think we're ready to ship!

Thank you so much for your work on this! Open source collaboration for the win! :D

thomthom commented 3 years ago

Doh, need to generate PDF versions for mac!

thomthom commented 3 years ago

0.15.0 is live on Extension Warehouse and SketchUcation.