thomthom / skippy

CLI Development tool for SketchUp extensions
MIT License
21 stars 5 forks source link

Ruby exception from unconventional SketchUp version #41

Closed Eneroth3 closed 3 years ago

Eneroth3 commented 4 years ago

Unconventional SketchUp folder names with text after the version number causes a Ruby exception on this line.

https://github.com/thomthom/skippy/blob/e3ec2101d5d862877747cde2b14806d2dcc84751/lib/skippy/os/win.rb#L31

Either the regex needs to be more generous to support these formats, or it should be checked if there is a match at all before calling [], preferably with a warning saying it's an unexpected name.

This affects the debugger in VSCode which uses Skippy to list SketchUp installs.

Postur commented 3 years ago

This has been fixed with this commit