search

thomthom / solid-inspector

Inspect and repair solid groups and components in SketchUp.
https://extensions.sketchup.com/en/content/solid-inspector%C2%B2
MIT License
18 stars 2 forks source link

Detect edges of self-touching solids #29

Closed thomthom closed 9 years ago

thomthom commented 9 years ago

Original report by Aerilius (Bitbucket: Aerilius, GitHub: Aerilius).

The original report had attachments: solid_with_shared_edge.skp

solid_with_shared_edge.zip

A solid whose surface touches itself at one edge (this edge then has 4 neighbouring faces) is neither recognized by SketchUp as a solid, nor is it recognized by SolidInspector² as an error.

thomthom commented 9 years ago

Original comment by Aerilius (Bitbucket: Aerilius, GitHub: Aerilius).

I agree that it's maybe rather something that needs improvement in SketchUp's solid checker.

A user sees in Entity Info not a solid (according to SketchUp's definition), and wants to find out why SketchUp doesn't detect it. But if this extension's goal is focussed on real solidness/printability (and not debugging whether something is solid to SketchUp's definition), then it's perfectly comprehensible. I just wanted to knwo your opinion.

thomthom commented 9 years ago

SketchUp doesn't recognize this as a manifold because not all edges connects to two faces - which is a very naive test that doesn't account for this edge case. It is however a valid solid. The model should be printable.

I'm closing this as an invalid issue as the goal of Solid Inspector is not to match what SketchUp says is a solid, but provide a better analysis.

If you think that this edge case is a problem that should be marked as an error then please object and I'll certainly listen.