Replace JamesIves/github-pages-deploy-action by actions/deploy-pages

thomvaill / log4brains

✍️ Log and publish your architecture decisions (ADR)

Apache License 2.0

1.15k stars 95 forks source link

Replace JamesIves/github-pages-deploy-action by actions/deploy-pages #133

Open thomvaill opened 2 weeks ago

thomvaill commented 2 weeks ago

Probably better to use the official Github actions, which does not involve the use of another branch anymore.

[ ] In .github/workflows/on-merge-to-develop.yml
[ ] In our README.md example if it works correctly

mervyn-mccreight commented 2 weeks ago

I'd be interested in contributing here.

Using the deploy-pages action might need some configuration in the pages-settings of the repository which I'd not be able to do myself though (I think the steps needed are configuring "GitHub Actions" as build & deployment source for pages and I'm not sure whether this happens automatically after configuring that or if it has to be done manually, but one might need to create an environment named "github-pages").

thomvaill commented 1 week ago

Cool!

Yes you can submit a PR and then I'll update these settings:

I'll switch to "Use GitHub Actions"

Thank you for your help