search

thomvaill / log4brains

✍️ Log and publish your architecture decisions (ADR)
Apache License 2.0
1.13k stars 95 forks source link

Decision Log Package Filtering #93

Open rdurham285 opened 2 years ago

rdurham285 commented 2 years ago

Feature Request

Feature Suggestion

It would be of great value if we could get some views that were filtered down by a given package.

Context

Managing a long lived monorepo with lots of ADRs could grow cumbersome. We are also adopting ADR for decision making for our enterprise where we intend to model certain business and technical areas as packages, where it would be valuable to view those decision areas separately from the global adr population.

Possible Implementation

On the left side in the visual representation of the decision log, a drop down or method of picking a package that filters it down to the decisions in the package would be one way to implement this.

qtzar commented 1 year ago

I would also love to see this feature added. The possible implementation that is outlined above of a dropdown would work well.

tylerhubert commented 1 year ago

I wanted this functionality as well, so I've implemented a simple version of this request in #99. Please provide feedback if you would like!

qtzar commented 1 year ago

@tylerhubert I just wrapped up very similar code in my fork to add this functionality also. I just couldn't get it to commit due to a typescript listing issue I'm still trying to resolve.

tylerhubert commented 1 year ago

@qtzar, I got around that by doing --no-verify on the commit. It seems like yarn lint will pass for me, but the husky pre-commits won't due to libraries (airbnb related I believe) that need to be updated. I guess we can see if @thomvaill is ok with that or not. :) I just opened up 3 PRs in the last day this same way, so I might have some rework to do if we need to get that handled.

tylerhubert commented 1 year ago

I suggest going with @qtzar's changes. :) The UI is formatted much nicer than mine and has more features.