`add -s` command accepts invalid emails.

[thony-ui]

• Description:
  The add -s command supports invalid emails.

• Steps to Reproduce:

  1. add -s n/John Doe p/98765432 e/johnd@example com/companyA t/friends t/owesMoney pro/rice pro/bread

• Expected Result:
  The supplier should not be added to the database as the email is invalid.

• Actual Result:
  The supplier was successfully added to the database.

[soc-se-bot]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Easy to accidentally enter wrong email

If a store manager is typing fast, it is very easy to make the following error:

The app accepts this email as valid, even though it is of a wrong format and is unusable. This would lead to inconvenience later on in case they want to copy and paste the email.

This is due to an issue with

1. The com/ company prefix :
   • it would have been more intuitive to use c/ instead, and there is no justification provided as to why com/ is the only prefix that is more than one character long.
2. Validity checks on email does not account for this mistake (but this is less serious as not all domain names end with .com, but most do, especially those related to suppliers).

It is simply the fact that this is an error users might easily make which can become an inconvenience down the road.

---

_{[original: nus-cs2103-AY2425S1/pe-interim#2465] [original labels: severity.Medium type.FeatureFlaw]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thank you for pointing this out, however, john@example is a valid email address according to the standard for email address format. The domain part of an email address can also be a local domain name with no TLD.

The standard for email addresses can be found here: https://tools.ietf.org/html/rfc5322#section-3.4.1

However, this can be hard to read and understand, so there are more references for valid email addresses format below:

https://stackoverflow.com/questions/20573488/why-does-html5-form-validation-allow-emails-without-a-dot https://stackoverflow.com/questions/27992870/should-email-validation-requires-the-domain-part-contains-a-dotjquery-validation/jquery-validation#2117 https://en.wikipedia.org/wiki/Email_address#Examples

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• [ ] I disagree

Reason for disagreement: [replace this with your explanation]

---

## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]

---