thooyork
commented
9 years ago Committed your PRs today.
Thanks for putting so much time and effort in fixing the issues!
Cheers Tom
On 06.04.2015, at 03:02, soif notifications@github.com wrote:
(should be applied after PR #6 or merge might not work)
• changeTime method renamed to setAlarm for consistency with clearAlarm method name • remove verbose console.log from index.html • setAlarm now accept either : • A date object • A string formatted either as : "hh" , "hh:mm", "hh:mm:ss" • more tolerant with string times inputs. • Alarm time now uses seconds precision (if set) • Documentation updated to reflect changes. BTW Thanks for having so fastly implemented all proposed issues. Cheers !!!!!!
You can view, comment on, or merge this pull request online at:
https://github.com/thooyork/thooClock/pull/7
Commit Summary
• Merge branch 'hotfix/resync' into develop • Merge branch 'hotfix/resync' • Merge branch 'feature/ffexample' into develop • Merge commit '2003dcc6175a5a6085f06da0b9a579ec74f9bc85' into develop • Merge branch 'develop' • Merge commit '6ce01355763752020cbd17d10bb46b4e0d351040' • fix startClock call • trigger ('offAlarm') on clearAlarm • clearAlarm doc • changeTime method renamed to setAlarm for consistency with clearAlarm method • remove alarmBg consoleLog • alarmTime as Date object or string like "hh", "hh:mm", "hh:mm:ss" + more tolerant on string input + Alarm time uses seconds precision (if set) File Changes
• M README.md (27) • M index.html (4) • M js/jquery.thooClock.js (41) Patch Links:
• https://github.com/thooyork/thooClock/pull/7.patch • https://github.com/thooyork/thooClock/pull/7.diff — Reply to this email directly or view it on GitHub.
soif
(should be applied after PR #6 or merge might not work)
BTW Thanks for having so fastly implemented all proposed issues. Cheers !!!!!! :+1: