thopiekar / rcraid-dkms

AMD RAIDXpert driver as DKMS package
Other
126 stars 27 forks source link

Makefile: Fix missing symbols in kernel starting from 4.20 #2

Closed Herrie82 closed 5 years ago

Herrie82 commented 5 years ago

Due to changes to the kernel build system, the rcblob was not picked up in the linking stage, leading to missing symbols in the rcraid.ko kernel module. Fixed by changing Makefile destinations and rules.

Credit for this fix goes to @martinkarlweber.

Signed-off-by: Herman van Hazendonk github.com@herrie.org

Herrie82 commented 5 years ago

Tested this on 4.15 and 4.19 and 4.20 on my (K)Ubuntu 18.04, seems to work OK. Seems since (K)Ubuntu 18.04 came with 4.15 I cannot really test older version.

On 4.19 and 4.20 I got a warning of redefined SECTOR_SIZE. I added an additional commit that applies the same patch as @martinkarlweber added with https://github.com/martinkarlweber/rcraid-patches/commit/1ca731b018784e3851722767ba7a37f67e77bb63

thopiekar commented 5 years ago

Great! Thank you for applying @martinkarlweber 's patches!