search

thopiekar / rcraid-dkms

AMD RAIDXpert driver as DKMS package
Other
126 stars 27 forks source link

Kernel 5.x issues #4

Closed Herrie82 closed 5 years ago

Herrie82 commented 5 years ago

Seems that with kernel 5.0.x there are some new issues cc @martinkarlweber

This is what I get from make.log while trying to install 5.0.3 on Kubuntu 18.04:

DKMS make.log for rcraid-8.1.0 for kernel 5.0.3-050003-generic (x86_64) vr 22 mrt 2019 9:59:10 CET make: Entering directory '/var/lib/dkms/rcraid/8.1.0/build/src'

Herrie82 commented 5 years ago

For .use_clustering seems we need to have .dma_boundary now as per: https://github.com/torvalds/linux/commit/4af14d113bcf95c12d1462ba623b7e7117bd3fb3#diff-89162e4d0981a374a20bfa001471fb2f

For do_gettimeofday there's a possible solutions in: https://lists.opensuse.org/opensuse-factory/2019-03/msg00199.html :

if (LINUX_VERSION_CODE >= KERNEL_VERSION(5, 0, 0))

u64 ts; ts = ktime_get_boottime(); return ts/1000;

else

struct timeval tv; do_gettimeofday(&tv); return ((u64)tv.tv_sec * 1000000) + tv.tv_usec;

endif

For access_ok see: https://github.com/tonyhutter/zfs/commit/916bb5f8f2e3956660fc347b3a98edf4f8d788d3

thopiekar commented 5 years ago

Hmm, might be that they are still changing the API. At the moment I don't have much time to look into this. I just contacted AMD about incompatibilities of their Windows driver on more recent Windows builds. Also began to do some patchwork on the RAID drivers webinterface for Linux.

So might be that I will bundle all work - rcraid-dkms, rcraid cli tools and rcraid webui - into a new repository. The current ones naming is just to specific to the kernel driver.

thopiekar commented 5 years ago

@Herrie82 Thank you for the research! :+1:

Herrie82 commented 5 years ago

I might get to actually push something, just don't really know how to test the new code with dkms. Still very new to linux on desktop ;)

thopiekar commented 5 years ago

You will find all sources here:

$ ls /usr/src/
bbswitch-0.8/                    linux-headers-4.18.0-15/         linux-headers-4.18.0-16/         nvidia-390.116/                  .tmp_versions/                   
kpatch-0.5.0/                    linux-headers-4.18.0-15-generic/ linux-headers-4.18.0-16-generic/ rcraid-8.1.0/                    virtualbox-5.2.18/

You can do modification there as root (sudo nano /foo/bar) and tell dkms to rebuild rcraid.

Herrie82 commented 5 years ago

@thopiekar Thanks :)

I'll try to keep the patches minimal and straight forward. As usual there are multiple ways to Rome, but will try to stick to the easy solution. With a simple kernel version check as was done previously where possible.

thopiekar commented 5 years ago

That would be great! I think we all agree that the sources should build against all kernel versions possible. 🙂

Herrie82 commented 5 years ago

Should be fixed with https://github.com/thopiekar/rcraid-dkms/pull/5