Closed mbana closed 2 years ago
Does it build on older kernels still? See that you've included #include <scsi/sg.h> - since when does it exist?
PS: If it is a new header, please put your code in #if LINUX_VERSION_CODE <= KERNEL_VERSION(X,Y,Z)
sections, so the driver can be built on older kernel versions still.
Does it build on older kernels still? See that you've included #include <scsi/sg.h> - since when does it exist?
Define older kernels, please.
To answer the question, I didn't check. I tried what I mentioned earlier. Is suggest you have a GitHub workflow that builds on different OSes and/or kenels. At least that way one can be somewhat sure, their changes buillds.
Nope, never had the time to prepare something like this.
I would be interested in having this working for the last Ubuntu LTS at least, which is version 5.4.x
.
If you could make a quick check on this version that would be great :)
Nope, never had the time to prepare something like this. I would be interested in having this working for the last Ubuntu LTS at least, which is version
5.4.x
. If you could make a quick check on this version that would be great :)
The CI pipeline can be viewed at: https://github.com/banaio/rcraid-dkms/actions/runs/1578132114.
The corresponding CI file can be viewed at: https://github.com/banaio/rcraid-dkms/blob/5.15.6-200.fc35.x86_64/.github/workflows/rcraid-dkms-ci.yml.
It's building on ubuntu-18.04
and ubuntu-20.04
using, I believe, the 5.4.0
Kernel.
Awesome! From my experience, things can break while loading the driver still and give kerneloops. But yeah, let's cross fingers and see what it gives. We can revert and/or rework the changes made here later if needed.
Thank you for your efforts!
#include <scsi/sg.h>
is needed for newer Kernel.scp->request
has been removed andscsi_cmd_to_rq(scp)
should be used instead.Before:
After: