search

thor27 / steam-login

Put STEAM BigPicture mode at login screen
121 stars 30 forks source link

Random updates #37

Closed nefelim4ag closed 6 years ago

thor27 commented 6 years ago

Thanks a lot for your contribution, there is a few comments I would like to discuss regarding your patch, hope you have time to address them.

thanks!

nefelim4ag commented 6 years ago

@thor27, i just think about rewrite several parts, so i will do that soon. After, i will inform you there, to get your opinion.

Thanks!

nefelim4ag commented 6 years ago

So, look at that.

Thanks!

thor27 commented 6 years ago

Hi, checked and tested your patch and seems to work nice. (and a great refact! Thanks a lot for that contribution :)

First about openbox: I had a few issues with it, most regarding focus issues, but the way you did to support it optionally seems perfect for me.

Second, I've tried the "steam -shutdown" here and it's working fine. The only problem I found about killing it without trying to shutdown nicely is that the next time steam starts it loads the update screen. I don't know if there is any other issue doing that.

This is normally triggered when you click on "exit bigpicture mode" instead of "exit steam" while on steam-de.

Maybe we could try to check if steam is still running in the background, and if it is try to use the steam -shutdown and if doesn't works kill it.

nefelim4ag commented 6 years ago

@thor27, look at that: https://github.com/thor27/steam-login/pull/37/commits/18c62bc449c31120c0c210b308ccd0089ff691f9

That must do a trick =.=''

thor27 commented 6 years ago

@Nefelim4ag seems ok to me, I will merge as get home and test it.

Thanks! :+1: