search

thor314 / pebble-stark

A community-developed re-implementation of the Starkware Stone Prover
70 stars 6 forks source link

Migrate starkware/math #5

Open thor314 opened 11 months ago

thor314 commented 11 months ago

Migrate math.

Relatively self-contained, only about 300 lines of code.

agnxsh commented 11 months ago

https://docs.rs/num-traits/0.2.17/num_traits/ any thoughts about this? it should have the things like modular arithmetic.

thor314 commented 11 months ago

maybe overkill; many of these methods already exist in the standard library, or are accessible through a finite-field trait, I think Arkworks is re-exporting from num_traits, might b better to use ark_ff instead unless there's a specific reason to use num-traits

agnxsh commented 11 months ago

sure that works as well, okay.