search

thorio / KGrabber

Userscript for extracting links from kissanime.ru and similar sites.
https://greasyfork.org/en/scripts/383649-kissgrabber
GNU General Public License v3.0
34 stars 12 forks source link

Add quality selection for kimcartoon #36

Open kittybitme opened 4 years ago

kittybitme commented 4 years ago

Description Regardless of the settings, extracting links from any given server (either from the "Extract links" button or the "Grab" button next to each individual episode) will result in the 720p link being returned.

Information

  1. Browser: macOS Chrome Version 80.0.3987.100
  2. Userscript Manager: Tampermonkey
  3. Show, Episode: Craig of the Creek S2, any/all episodes
  4. Server: Any

Additional information I tried digging into the userscript a bit to see what was wrong, but I couldn't pinpoint anything specific.

thorio commented 4 years ago

This is because the default grabber (which is used for kimcartoon) doesn't actually support quality selection. It just takes whatever it can get, which is usually 720p since it's selected by default. I have updated the wiki page to make this more apparent.

I personally rarely, if ever, use this script for sites other than kissanime, so i don't really want to spend the time to implement this. If you want to take a shot at it yourself though, the relevant code is here.

kittybitme commented 4 years ago

Thanks for the info! I'll take a look at the relevant block and see if I can't suss something out.