search

thoriqadillah / moodle-qtype_essaysimilarity

Is a moodle question type plugin that compares the similarity between student's answer and teacher's answer key using machine learning (natural language processing), and uses the similarity to auto grade the answer. The automatic grade can be manually overridden by the teacher
https://thoriqadillah.github.io/cat-n-code/projects/essay-similarity/#demo
GNU General Public License v3.0
2 stars 3 forks source link

change param_text to param_alpha #14

Closed thoriqadillah closed 1 year ago

thoriqadillah commented 1 year ago

This PR solve #9

Changing PARAM_TEXT to PARAM_ALPHA and add clean_param() on class constructor to clean the parameter before using it on tokenizer function. With this, hopefully will prevent potential option for directory traversal attack. Thanks to @danmarsden.

This PR also update the code to solve #7

danmarsden commented 1 year ago

that definitely reads as being a lot safer when reviewing the code :-)

thoriqadillah commented 1 year ago

in that case, with the closing of this PR, I have taken care of all the issues you previously mentioned