thoriqadillah / moodle-qtype_essaysimilarity

Is a moodle question type plugin that compares the similarity between student's answer and teacher's answer key using machine learning (natural language processing), and uses the similarity to auto grade the answer. The automatic grade can be manually overridden by the teacher
https://thoriqadillah.github.io/cat-n-code/projects/essay-similarity/#demo
GNU General Public License v3.0
2 stars 3 forks source link

thirdpartylibs file further investigations.... #18

Open danmarsden opened 4 months ago

danmarsden commented 4 months ago

You have a stemmer lib from: looks like it's from: https://github.com/angeloskath/php-nlp-tools/blob/master/src/NlpTools/Stemmers/PorterStemmer.php and it uses the wtfpl license - that should be covered in the thirdpartylibs.xml file.

also looks like you include: https://github.com/sastrawi/sastrawi/blob/master/data/kata-dasar.txt which is an MIT licensed file (which should also be listed in the thirdpartylibs.xml file.)

and: https://github.com/ilhamdp10/algoritma-stemming-nazief-adriani/blob/master/enhanced_CS.php

and: https://github.com/jorgecasas/php-ml/blob/develop/src/FeatureExtraction/TfIdfTransformer.php MIT License

and: https://github.com/angeloskath/php-nlp-tools/blob/master/src/NlpTools/Tokenizers/WhitespaceTokenizer.php

and: https://github.com/angeloskath/php-nlp-tools/blob/master/src/NlpTools/Similarity/CosineSimilarity.php

While you've credited the original authors in some of those places - you need to reference them in the thirdpartylibs.xml file and also be clear what license those files are provided under.

thoriqadillah commented 3 months ago

what if the code that i use has no license like this URL https://github.com/ilhamdp10/algoritma-stemming-nazief-adriani/blob/master/enhanced_CS.php? do i just write it this way?

<library>
    <location>nlp/stemmer/id/id.php</location>
    <name>Nazief Adriani</name>
</library>
danmarsden commented 3 months ago

if it doesn't have a license - you will need to ask the author to provide one, or you will need to exclude it from the plugin zip itself.

I had a similar issue with the wechat payment plugin - they provide an SDK but didn't license it in a way that allowed me to distribute it within the GPL plugin. https://github.com/catalyst/moodle-paygw_wechat