php7 and constructors - Githubissues

thoroc / php_writeexcel

Johann Hanne's php lib to write excel file

14 stars 15 forks source link

php7 and constructors #7

Closed vpil closed 8 years ago

vpil commented 8 years ago

For php v7 compatibility it is needed to get rid of php v4-style constructors. ie. replace public function writeexcel_worksheet(... with public function __construct(...

And appropriate calls, ie: replace $this->writeexcel_biffwriter(); with parent::__construct();

Thank you

thoroc commented 8 years ago

Committed a php5+ branch with the __construct() change requested. I haven't got the time to test it properly. Could you try it and let me know?

vpil commented 8 years ago

Just one more constructor rename in class.writeexcel_worksheet.inc and everything seems OK. Thank you.

thoroc commented 8 years ago

Sorry didn't see that one :/