thorpelawrence / alexa-spotify-connect

Control Spotify Connect devices with Alexa
MIT License
97 stars 53 forks source link

Add separate intent for setting the volume to a percentage #81

Closed visadb closed 3 years ago

visadb commented 3 years ago

This fixes issue #80.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 334


Changes Missing Coverage Covered Lines Changed/Added Lines %
connect.js 28 30 93.33%
<!-- Total: 28 30 93.33% -->
Totals Coverage Status
Change from base Build 328: 2.2%
Covered Lines: 163
Relevant Lines: 196

💛 - Coveralls
visadb commented 3 years ago

I'll write tests for the new intent.

thorpelawrence commented 3 years ago

Looks good to me! Were you able to test this manually by any chance?

visadb commented 3 years ago

Looks good to me! Were you able to test this manually by any chance?

Nope, I'm new to Alexa skill development and didn't want to expend the time and energy to setup things for manual testing. And it's hopefully too simple a change to botch. 😅

thorpelawrence commented 3 years ago

No problem, I will merge it and submit to Amazon, which might take a few days for approval

Thanks!

thorpelawrence commented 3 years ago

Hi @visadb

Amazon have accepted the changes so it should be live now, thanks again