search

thorpelawrence / alexa-spotify-connect

Control Spotify Connect devices with Alexa
MIT License
97 stars 53 forks source link

Update pt-BR.json #99

Closed rafaferreirasantos closed 1 year ago

rafaferreirasantos commented 1 year ago

Hi Thorpe, it wasn't making sense in Portuguese. The "pause" samples was conflicting with the default "stop" command. The previous file had some slots that didn't exists.

Thank you. Sorry about not include comments in the pr

Em sáb., 5 de nov. de 2022 07:10, Lawrence Thorpe @.***> escreveu:

@.**** commented on this pull request.

Hi, thanks for the PR - it looks like a few samples were removed, is there a reason for that?

In skill/locales/pt-BR.json https://github.com/thorpelawrence/alexa-spotify-connect/pull/99#discussion_r1014614742 :

  • ],

  • "samples":[

  • "anterior",

  • "voltar"

  • ]

  • },

  • {

  • "name":"VolumeLevelIntent",

  • "slots":[

  • {

  • "name":"VOLUMELEVEL",

  • "type":"AMAZON.NUMBER"

  • }

  • ],

  • "samples":[

  • "definir volume em {VOLUMELEVEL}",

⬇️ Suggested change

  • "definir volume em {VOLUMELEVEL}",

  • "definir volume em {-|VOLUMELEVEL}",

A few places like this

— Reply to this email directly, view it on GitHub https://github.com/thorpelawrence/alexa-spotify-connect/pull/99#pullrequestreview-1169389651, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVSNA34TVJ5BQ3WPWEOOSDWGYXABANCNFSM6AAAAAARXXYHGY . You are receiving this because you authored the thread.Message ID: @.*** com>

thorpelawrence commented 1 year ago

Thanks, makes sense. There's just a few places with placeholders that might need to be updated left

rafaferreirasantos commented 1 year ago

Your skill is not working in PT-BR. After list the available devices it can't do anything. I think that is the reason the skill has low ratings among brazilian users. The person who create this pt-br file may had a wrong understanding of this. He replaced the name of the devices for numbers, etc, insert multiple words between curly brackets (trying to use like options but the skill hopes slots between brackets). If you get his "intends" and paste it in the skill console it won't build.

After my adjustments it will work.

;)

Em sáb., 5 de nov. de 2022 09:04, Lawrence Thorpe @.***> escreveu:

Thanks, makes sense. There's just a few places with placeholders that might need to be updated left

— Reply to this email directly, view it on GitHub https://github.com/thorpelawrence/alexa-spotify-connect/pull/99#issuecomment-1304520557, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVSNA2VKFNNQJKM6FNAOBDWGZEN7ANCNFSM6AAAAAARXXYHGY . You are receiving this because you authored the thread.Message ID: @.***>