search

thorrak / brewpi-esp8266

An implementation of the BrewPi device code on the ESP8266, ESP32, and ESP32-S2
GNU General Public License v3.0
86 stars 30 forks source link

LCD showing only 1st character of each item #28

Closed art-h closed 1 year ago

art-h commented 5 years ago

Compiling the master branch using Visual Studio Code & PlatformIO generates code that only displays the first character of each bit of text on the LCD screen (via Fermentrack, no physical LCD on my system, but I think it would behave the same).

Something like:

M F C B - - ° F 7 7 ° I i 5

instead of:

Mode Fridge Const. Beer --.- --.- °F Fridge 71.7 73.0 °F Idling for 5h21m50

It appears the IIClcd.print function in the current set of platform code and supporting packages might have some issues. I've duct-taped together a fix via lilcd.h, lilcd.cpp, and DisplayLCD.cpp, but it's not exactly elegant. Here's the build info, in case there's something obvious in the configuration that might fix it:

Processing esp8266_wifi (platform: espressif8266; board: nodemcuv2; framework: arduino)

Verbose mode can be enabled via -v, --verbose option CONFIGURATION: https://docs.platformio.org/page/boards/espressif8266/nodemcuv2.html PLATFORM: Espressif 8266 2.2.2 > NodeMCU 1.0 (ESP-12E Module) HARDWARE: ESP8266 80MHz, 80KB RAM, 4MB Flash PACKAGES: toolchain-xtensa 2.40802.190218 (4.8.2), tool-esptool 1.413.0 (4.13), tool-esptoolpy 1.20600.0 (2.6.0), framework-arduinoespressif8266 2.20502.0 (2.5.2) LDF: Library Dependency Finder -> http://bit.ly/configure-pio-ldf LDF Modes: Finder ~ chain, Compatibility ~ soft Found 29 compatible libraries Scanning dependencies... Dependency Graph |-- 1.0.0 #4775b1d | |-- 1.1.1 | | |-- 1.0 | |-- 1.2 | | |-- 1.0 | |-- 1.0 | |-- 1.0 | | |-- 1.0 |-- 1.2 | |-- 1.0 |-- 1.0 | |-- 1.0 |-- 1.0 |-- 1.1.1 | |-- 1.0 |-- 1.0 Linking .pio/build/esp8266_wifi/firmware.elf Retrieving maximum program size .pio/build/esp8266_wifi/firmware.elf Checking size .pio/build/esp8266_wifi/firmware.elf Memory Usage -> http://bit.ly/pio-memory-usage DATA: [==== ] 38.4% (used 31420 bytes from 81920 bytes) PROGRAM: [==== ] 39.8% (used 415744 bytes from 1044464 bytes) ============================================== [SUCCESS] Took 3.22 seconds ==============================================

I'll be glad to check in my code if it's useful to help fix the issue, but I'm hoping someone that is more familiar with the code can give it a proper fix.

zrgravity commented 5 years ago

Do you use the LCD? I was able to get the same working by commenting out the LCD definitions in Config.h and DefaultConfig.h

mp-se commented 4 years ago

Its a change in the underlaying arduino libraries that causes this. I have submitted a fix that has not been merged yet

thorrak commented 4 years ago

As @mp-se noted, I haven't yet merged the change in. The existing binaries should work, but new compilations need the changes that he submitted the pull request to make. I have been focused on an alternative implementation for the past few months and haven't had a chance to test the change on newly-compiled firmware but this change will get merged as soon as I can get it tested.

Thanks again @mp-se - sorry for the delay on this!

art-h commented 4 years ago

Hi @thorrak - have you been able to make this merge and test it yet? Alternatively, how's the alternate implementation coming along? Thanks!

mp-se commented 4 years ago

Use this for now, it has the LCD issue fixed... or you can fix it yourself, just one character to change ... https://github.com/mp-se/brewpi-esp8266

PoulKlemmensen commented 3 years ago

Use this for now, it has the LCD issue fixed... or you can fix it yourself, just one character to change ... https://github.com/mp-se/brewpi-esp8266

Thanks. I have just been trying to compile the code myself and ran into the same issue. Want to change some constants and maybe add fan control if I can.

speshak commented 3 years ago

@PoulKlemmensen You may want to work off of the esp32 branch. Despite the name, it has a load of refactoring work not related to esp32 merged into it that might make your experience a little better.

thorrak commented 3 years ago

@PoulKlemmensen as @speshak suggested, I highly recommend any new work being done off the esp32 branch. (Plus, if you want the future goodies that will eventually come with the esp32 branch, it will be a lot easier to pull them into your fork ;) )

PoulKlemmensen commented 3 years ago

Hi. Sorry for not doing my homework properly and thanks for pointing this out to me? When you are talking about the ESP32 brach, are you then referring to Brewpi remix?

thorrak commented 3 years ago

Hi. Sorry for not doing my homework properly and thanks for pointing this out to me? When you are talking about the ESP32 brach, are you then referring to Brewpi remix?

There’s no documentation on this specific choice, so there’s no way you could have known. When we are referring to the ESP32 branch, we mean “branch” in the Git context. Specifically, we mean this: https://github.com/thorrak/brewpi-esp8266/tree/esp32

The BrewPi-Remix firmware is specifically for the Arduino Uno, not an ESP8266/ESP32.