search

thorrak / brewpi-esp8266

An implementation of the BrewPi device code on the ESP8266, ESP32, and ESP32-S2
GNU General Public License v3.0
86 stars 30 forks source link

Change level shifter to most recent version #30

Closed wvolz closed 4 years ago

wvolz commented 5 years ago
CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

thorrak commented 4 years ago

Hey there!

First - an apology. I should have responded to this pull request when it was submitted months ago. I missed seeing it, and - had I seen it - would have looked to get it merged ASAP.

In part as a result of (finally) seeing this last weekend, I went through and redesigned the boards that use the "sparkfun" level shifter, including making the change to the new board as you recommended. The new boards are posted to the repo, and should be available for download. Other changes included in this redesign were to reorganize the boards to guarantee they will all (with the exception of the "No LCD" boards) fit in the 3D printed case, all use RJ-45, and all are arranged such that I can come back later and tweak the OneWire and relay pinouts. As this change incorporates the change for which you submitted the pull request, I'm going to close the request.

Thanks again for this - had you not submitted this pull request I would not have known that the module incorporated in the design was the old one, and would not have made this update.