Add ability to name & log an arbitrary number of temperature probes

[speshak]

I have additional temp probes that aren't one of the beer/fridge/room options. I'm using fermentrack/brewpi-8266 to control glycol chill loops on my fermenters. I'm ok with the control probes not have "correct" names (for example, my fermenter probe is configured as the fridge probe in fermentrack), but I'd like to at least be able to log the data from these extra probes.

I personally have a probe for the coolant bath and for the post-jacket coolant temp, but I think any solution should allow arbitrary names to be set on these non-control probes.

[uSlackr]

(sorry if off topic) Why don't the three probes have the right names? That is configurable

\Greg

[speshak]

I couldn't get it to actually cool when using just a beer temp probe. The interface says that chamber (aka fridge) is required. Because of that the probe that is in my fermentor is my chamber probe. (I don't actually have a chamber, because I'm using glycol)

[uSlackr]

I would think the beer probe is the beer probe, the glycol is the chamber/fridge and the outside is the room. No?

\Greg

[speshak]

Not quite. The beer is the beer, but the glycol is not the chamber because the glycol is kept at a constant temp by a controller built into the chiller. The control point is turning the coolant pump on and off to change the fermenter temp. (Said another way: I'm not controlling the temp of the glycol. I'm using cold glycol to control the temp of the fermenter.)

[uSlackr]

Sure. But the glycol is equivalent to the cool fridge air. The coming cycle would just turn on the pump to initiate cooling instead of the fridge.

\\ Greg

---

From: Scott Peshak notifications@github.com Sent: Saturday, August 29, 2020 10:46:09 PM To: thorrak/fermentrack fermentrack@noreply.github.com Cc: uSlackr gmartin@gmartin.org; Comment comment@noreply.github.com Subject: Re: [thorrak/fermentrack] Add ability to name & log an arbitrary number of temperature probes (#492)

Not quite. The beer is the beer, but the glycol is not the chamber because the glycol is kept at a constant temp by a controller built into the chiller. The control point is turning the coolant pump on and off to change the fermenter temp. (Said another way: I'm not controlling the temp of the glycol. I'm using cold glycol to control the temp of the fermenter.)

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fthorrak%2Ffermentrack%2Fissues%2F492%23issuecomment-683368776&data=02%7C01%7C%7C62b22001f9724c64ec9008d84c8edb43%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637343523726645619&sdata=jzP2zIo%2FDUgZCjj%2B43HEs60mxzI5J8QJxdaI6hLXhiw%3D&reserved=0, or unsubscribehttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAGEO6Z42DI7FQKAXHO7PJWTSDG4PDANCNFSM4QO75GHA&data=02%7C01%7C%7C62b22001f9724c64ec9008d84c8edb43%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637343523726655616&sdata=x66OqG%2FPWbXLcv8IYoWdv2%2F1MGLbwMh%2BHvjZKseDKWw%3D&reserved=0.

[speshak]

I think I'm tracking what you mean now. I thought there was some reason why I couldn't get it to work that way. I'll play with it a bit more and see if I can capture the details. We're straying a bit far afield of the original intent of this issue. 😁

[thorrak]

The BrewPi control model directly controls the "fridge" temperature in order to indirectly control the "beer" temperature. This is why the "fridge" sensor is mandatory for a BrewPi controller to work. For most glycol setups, this means that:

• Your "fridge sensor" should actually go in your beer
• There is no "beer sensor" (though you could also have it in your beer)
• The controller handling your fermentation temps will not control the temperature of your actual glycol

...and the room sensor is (as always) optional.

[thorrak]

We're straying a bit far afield of the original intent of this issue. 😁

How are your additional temperature probes connected? The BrewPi-ESP8266 port only supports reporting the three typical probe types (fridge/beer/room) - are you using additional hardware?

[speshak]

The additional probes are just more probes on the OneWire bus. I am using a custom PCB based off yours that has additional probe connectors.

The probes show up fine as uninitiated devices, I just want to get their data into the CSV.

[thorrak]

The additional probes are just more probes on the OneWire bus. I am using a custom PCB based off yours that has additional probe connectors.

The probes show up fine as uninitiated devices, I just want to get their data into the CSV.

Ah, makes sense. This is a controller thing more than a Fermentrack one (for now) - this can be done but requires additional work. I’m moving this issue to the controller issue board for tracking.

[speshak]

👍 I wasn't entirely sure where the bulk of the changes would have to go. I'm more than happy to try to take a stab at the change. Do you have any opinions on what the change would look like?

[speshak]

I made a first stab at getting all of the temp probes into the t output: https://github.com/speshak/brewpi-esp8266/commit/5e4d8e2161c223da99e60c01241d8f9be340d0e7 This extends the existing JSON response with a rawDevices key which points to an array of sensor information. An example from my test setup:

"rawDevices": [{"device": "28E4D922292001B4", "value": 23.375},{"device": "28CAD17C292001E2", "value": 23.250},{"device": "285B4E17292001B8", "value": 23.063}]

I'm going to fiddle a bit more to see about adding support for setting names on the probes. Worst case that can be done on the consuming side, so I won't spend a massive amount of time on it.

[speshak]

After playing with my change a bit, I decided that it slows down the temp report too much (and understandably gets longer as more probes are added)

I added a new command, tentatively named 'T' to get the raw device readings. This should minimize the impact my crazy feature has on other users.

[speshak]

46 Fixed this issue.