thorrak / brewpi-esp8266

An implementation of the BrewPi device code on the ESP8266, ESP32, and ESP32-S2
GNU General Public License v3.0
86 stars 30 forks source link

Setting temp control to "OFF" triggers incorrect message #61

Closed thorrak closed 1 year ago

thorrak commented 3 years ago

When temperature control is set to off, the code that sets it to "off" also sets the fridgeSetting to INVALID_TEMP. The code that processes the temp mode overrides the mode to IDLE if the fridgeSetting is set to INVALID_TEMP resulting in MODE_OFF never being (properly) applied.

The result appears to be a race condition, where the LCD can end up with improper idle times printed over the top of a temp control off message, in addition to an inconsistent state more broadly.