search

thorrak / fermentrack

A replacement web interface for BrewPi
MIT License
134 stars 61 forks source link

Control Settings Management #65

Open thorrak opened 7 years ago

thorrak commented 7 years ago

At the moment, the script properly handles control constants. Nothing is done about control settings, however.

I'm not sure if this is something we really care much about or not. Once we get past the initial release it would be good to see if people actually want to view/touch control settings. If not, then the stubbed out code can be deleted.

blottootto commented 6 years ago

Is it on purpose that the control constants page just has empty fields? I need to adjust some settings because my integrator is way out of whack at the moment. Problem is that I don't even know what the current values are.

thorrak commented 6 years ago

Nope. Are you using an Uno or an ESP8266?

blottootto commented 6 years ago

Uno

thorrak commented 6 years ago

Thought so. I had a new Uno delivered yesterday to look at this exact issue, believe it or not. Should hopefully have a fix soon (right after I exploit its uninitialized eeprom to fix #245)

blottootto commented 6 years ago

Super. I'll report back once I see some commits for this. Thanks!

thorrak commented 6 years ago

@blottootto - The fix for control constants on Arduino-based devices is now live. Let me know if you have any further issues.

blottootto commented 6 years ago

Works great. Thanks

NamelessCoder commented 6 years ago

I don't mean to hijack this issue so please let me know if I should open a new one. I experience the same empty control constants fields with my OEM BrewPi spark 3 (over WiFi).

For me, filling the fields with default/selected values is not very important as long as new values can be saved to the device. But if you could assist me with for example a screen shot or quick list that shows the default values I would very much appreciate that!

thorrak commented 6 years ago

@NamelessCoder - I've created a new issue #282 to track what you're looking for. The problem is that the control constants themselves changed dramatically between 0.2.x and 0.4.x/0.5.x controllers. You can't use the OldControlConstants model to manage modern controllers as most of the options no longer exist. There is already an (untested) NewControlConstants model in Fermentrack, but the code to use it doesn't exist yet.

Option113 commented 5 years ago

@thorrak How can I use the OldControlConstants. My constant are empty...