search

thorrak / tiltbridge

Tilt Hydrometer to WiFi Bridge
http://www.tiltbridge.com/
Other
61 stars 27 forks source link

General settings page update fails because of mdnsID validation #131

Closed pletch closed 3 years ago

pletch commented 3 years ago

Any attempt to update the Settings --> General Settings tab fails on fresh devel branch install.

    183969 W: Settings update error, [mdnsID]:(tiltbridge) not valid.
    183973 V: Processing [tzOffset]:(-5) pair.
    183977 N: Settings update, [tzOffset]:(-5) applied.
    183982 V: Processing [tempUnit]:(F) pair.
    183986 N: Settings update, [tempUnit]:(F) applied.
    183991 V: Processing [smoothFactor]:(60) pair.
    183995 N: Settings update, [smoothFactor]:(60) applied.
    184000 V: Processing [invertTFT]:(true) pair.
    184005 N: Settings update, [invertTFT]:(true) applied.
    184010 E: Error: Invalid controller configuration.

I think this is because 

                LCBUrl url;
                if (!url.isMDNS(value))

in function processTiltBridgeSettings expects to see .local on the end of the MDNS name being validated.

lbussy commented 3 years ago

Heh, I know where I broke that. :)

I'll get it in a few, thanks for pointing it out.