search

thorrak / tiltbridge

Tilt Hydrometer to WiFi Bridge
http://www.tiltbridge.com/
Other
61 stars 27 forks source link

Tiltscanner advertised hex string parsing function updates #34

Closed pletch closed 3 years ago

pletch commented 3 years ago

Modified load_tilt_from_advert_hex function to eliminate use of NimBLEUtils::buildHexData by instead leveraging fixed char arrays.

The advert_hex_string is directly iterated to grab the color, temperature, and sp gravity data.

These changes appear to reduce heap thrashing when monitored via debugging output from esp_get_free_heap_size().

thorrak commented 3 years ago

Is there a reason you closed/deleted this? Is there a problem with this?

pletch commented 3 years ago

Honestly, I am a newb to making revisions to others projects on github and made a bit of a mess of the pull request when I tried to revise the initial commit after submission. The modifications do seem to work well for me as I have tested them over the last few days.

I will try again and send along another clean pull request.

Tim

On Mon, Oct 19, 2020 at 8:46 AM John notifications@github.com wrote:

Is there a reason you closed/deleted this? Is there a problem with this?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/thorrak/tiltbridge/pull/34#issuecomment-712132110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEIHK5C6WE45ZQJ7CGN36YTSLQYLPANCNFSM4SVGG5GQ .

thorrak commented 3 years ago

No worries! If you have trouble, let me know - I can see the changes you made, and they should be simple enough to replicate on my end and merge.