search

thorrak / tiltbridge

Tilt Hydrometer to WiFi Bridge
http://www.tiltbridge.com/
Other
61 stars 27 forks source link

Provide alert box if setting is invalid, set DHCP name correctly, add general timezone offset for use with google sheets. #46

Closed pletch closed 3 years ago

pletch commented 3 years ago

It bothered me that the settings page just returns silently if an invalid setting is input. I added some code to append an all_valid flag to the end of the json string when it is requested by the http client. This way, the javascript can pop up an alert box if one of the settings was found to be invalid by the process_config function. There is probably a better way to do this but this is the first approach I could come up with without more research into options.

pletch commented 3 years ago

Second commit takes another run at setting the DHCP hostname correctly. Putting the Wifi config flush in this location avoids the issue with the IP address showing as 0.0.0.0 on the initial wifi connect success screen. Seems to work reliably for me.

thorrak commented 3 years ago

I'm merging this into a new branch (tweaks) along with the MQTT topic changes you and @kidmock sent through. I figure I'll use that branch to stage the next release.

Separately, I'm looking through the google scripts notes you sent through on HBT and will come back on those shortly.