search

thorrak / tiltbridge

Tilt Hydrometer to WiFi Bridge
http://www.tiltbridge.com/
Other
61 stars 27 forks source link

Disable/enable buttons on POST #64

Closed lbussy closed 3 years ago

lbussy commented 3 years ago

This will disable buttons and show spinners when posting settings. Because I'm too slow to figure out how the calibration workflow works, I can't say whether it works there. Since that looks like a post, redirect, reload, I leave the buttons disabled on the calibration page and they just get re-enabled when the page reloads.

Not glamorous but I think it will work. The settings flow is sexeh though.

lbussy commented 3 years ago

@duncan-brown, was the calibration page your work? I feel like the slow kid for asking, but could you have a look at the [ui-work](https://github.com/thorrak/tiltbridge/tree/ui_work) branch and see if I broke it or not with my button trickery?

lbussy commented 3 years ago

@thorrak this should be ready now. We need to address #71 before this all can be merged into Master.

lbussy commented 3 years ago

cough ... NOW it's ready @thorrak . :)

(is Slack down for you?)

thorrak commented 3 years ago

It wasn't down - very strange.

thorrak commented 3 years ago

Nevermind - I think I'm having issues /w Slack

duncan-brown commented 3 years ago

@lbussy yes, I did the calibration page. If @thorrak hasn't already checked it, I'll take a look this coming weekend and open a pr if there are any issues.

lbussy commented 3 years ago

Thank you. I think he and I both agree our eyes cross when we look at this. Me for sure. :)