Asterisk in path causes checkout to fail

[drewnoakes]

Thank you so much for collating and sharing these images for the community 🙏

I am looking to integrate them into our test data suite for the Metadata Extractor project. Others are welcome to use those images as well:

https://github.com/drewnoakes/metadata-extractor-images

To integrate the data here into our project's regression test suite I'm going to fork this repo and add that fork as a submodule to our repo. The fork will exist because we'll want to write the output of the library to the repo alongside the image files, so we can track regressions as git diffs.

The issue I'm experiencing with the data in this repo is that the Pentax/*ist 20DL folder name causes the checkout to fail (on Windows at least) because * is an invalid character in a path name.

❯ git submodule add git@github.com:drewnoakes/digicam_corpus.git
Cloning into 'D:/repos/metadata-extractor-images/digicam_corpus'...
remote: Enumerating objects: 948, done.
remote: Counting objects: 100% (23/23), done.
remote: Compressing objects: 100% (22/22), done.
remote: Total 948 (delta 0), reused 21 (delta 0), pack-reused 925
Receiving objects: 100% (948/948), 1.09 GiB | 8.33 MiB/s, done.
Resolving deltas: 100% (165/165), done.
error: invalid path 'Pentax/*ist DL/IMGP6664.PEF'
fatal: unable to checkout submodule 'digicam_corpus'

To integrate the data here into our project's regression test suite I'm going to fork this repo and add that fork as a submodule to our repo. The fork will exist because we'll want to write the output of the library to the repo alongside the image files, so we can track regressions as git diffs.

I can rename the folder in the fork just fine, but I would prefer to keep the same name to allow easier synching with your upstream. Feel free to close this issue if you prefer to use the correct name in the folder.

[drewnoakes]

FYI I worked around this in https://github.com/drewnoakes/digicam_corpus/commit/f092c2ee7b70bc58bc537d35ddce8aba95a865e9.