thorsten-gehrig / KnxTpUart

This is the library of the KNX-User-Forum Arduino project initiated by thorsten Gehrig
45 stars 19 forks source link

Change UNKNOWN event to TPUART_UNKNOWN_EVENT to avoid conflicts #8

Closed PaoloTK closed 1 month ago

PaoloTK commented 1 month ago

Trying to use this library I'm facing conflicts with other libraries due to enum KnxTpUartSerialEventType having an item called "UNKNOWN". I have renamed this to "TPUART_UNKNOWN_EVENT" to minimize the chance of clashes happening. The other enum items (and other enums) have more specific names that are less likely to cause this problem. A better solution would be to convert all enums to enum classes, but I feel renaming the item is gonna require the least breaking changes for now.