thorswap / SwapKit

SwapKit SDK - Integrate blockchains easily. Docs - https://docs.thorswap.finance/swapkit-docs
https://swapkit.dev
Apache License 2.0
53 stars 28 forks source link

Missing Memos #899

Closed Rotwang9000 closed 2 months ago

Rotwang9000 commented 3 months ago

Current behavior

        const txData = {
            assetValue: assetValue,
            recipient: recipientAddress,
            from: sendingWallet.address,
            feeOptionKey: FeeOption.Average,
            chain: selectedToken.chain,
            memo: memo
        };
        console.log('Sending funds:', txData, sendingWallet);

            const txID = await skClient.transfer(txData);

The console logs:

assetValue: 
G { decimalMultiplier: 100000000n, bigIntValue: 100000000n, decimal: 8, address: undefined, chain: 'THOR', … }
chain:
"THOR"
feeOptionKey:
"average"
from:
"thor17a2dfukaum4f0c2dxvjw37mn35c2yal2yhqzyd"
memo:
"ABC100588119"
recipient:
"thor1wr4r0hw7apejj76xlxfxaw86r2v7r0ehl5sqg2"

...but no memo is in the transaction

https://runescan.io/tx/6499DC43CF707104FD655777973A4395708CB61362A7DEC174DF2AAB20319A9E

Expected behavior

The transaction to include the provided memo

Functionality

Packages

Details

Package versions:

├── @swapkit/plugin-chainflip@1.0.3
├── @swapkit/sdk@1.0.3
├── @swapkit/tokens@1.0.1
├── @swapkit/toolbox-radix@1.0.3
├── @swapkit/toolbox-substrate@1.0.3
Rotwang9000 commented 3 months ago

Can someone confirm if they are having the same problem, or if it's just me? Thanks.

Rotwang9000 commented 3 months ago

Anyone?!

ice-chillios commented 2 months ago

@Rotwang9000 - Not really - we are sending custom memos via .transfer method as well but will try to take a look this week for that on playground.

Rotwang9000 commented 2 months ago

Sorry forgot to close this... @towanTG helped me with a workaround (using client.getWallet(chain).transfer() ) but think it is fixed now anyways