search

thorvg / thorvg.web

ThorVG for Web System
https://www.thorvg.org
MIT License
3 stars 1 forks source link

Perf-Test: Performance (fps) is dropped until scrolling #5

Closed hermet closed 1 month ago

hermet commented 1 month ago

FPS shows lower results until the entire screen is scrolled. It seems to account for players outside the viewport. This needs to be rectified.

theashraf commented 1 month ago

I think it's because in dotlottie-react there is no check if the canvas is initially outside of the viewport or not before starting observing it

tinyjin commented 1 month ago

I think it should be applied in each player side. Do you think perf-test should tweak something to do this?

theashraf commented 1 month ago

@tinyjin Agreed, i've updated dotlottie-react with this patch, it's much better now