thorwe / CrossTalk

A Teamspeak 3 plugin that enhances the general audio experience and provides advanced features for commanders.
https://www.myteamspeak.com/addons/9ddfa0b2-25c2-4302-8a43-07f8819af9a9
MIT License
47 stars 12 forks source link

Change minimum update value to 0.02 #20

Open thorwe opened 9 years ago

thorwe commented 9 years ago

allow fastest update interval mumble link itself allows.

zsawyer commented 9 years ago

I'll create one for the minimum update value, however it'll be 0.02s as the mumble link protocol is at a fixed 50 times per second rate for updates.

Though 0.02 will give a fair quality I do not really see the point of artificially limiting this number when it is actually directly dependent on the server's setting. Meaning I would like to see the ability to go lower if desired. Though I haven't found the specific section I doubt that the protocol limits it to that rate only.

thorwe commented 9 years ago

Indeed it doesn't. While the Mumble Link Client indeed reads 50 times per sec, the recommendation for game developers is to update every frame.

Hence yes, I'll look at making the lowest possible. I might throw in an interims release with 0.02 though, since I'd like to do a code review for the whole part for those faster updates (might need to use a different timer implementation etc.).