search

thotasrinath / xk6-couchbase

K6 extension to test Couchbase DB
Apache License 2.0
5 stars 3 forks source link

Performance improvement by removing WaitUntilReady from individual operation #14

Closed Amar-C closed 2 weeks ago

Amar-C commented 2 months ago

Hi,

Looks like WaitUntilReady is called from individual operations. Do we need to call it before every operation? Can we just call it during initial connection setup? If we remove this from individual operation, we can gain ~15% more performance from this plugin (internal testing results)

thotasrinath commented 2 months ago

Thanks for the findings @Amar-C, I will make it optional.

sharathjag commented 1 month ago

Hi @thotasrinath I work with @Amar-C and can contribute towards this issue. Do you have few minutes to discuss how you want us to proceed? Let me know what time/timezone works for you.

thotasrinath commented 1 month ago

Hi @sharathjag, I am comfortable with SG timezone. Let me know when you would like to connect.

sharathjag commented 4 weeks ago

Thanks @thotasrinath I will send an invite your way. Is there a way to reach out to you?

Also opened: https://github.com/thotasrinath/xk6-couchbase/pull/17 Happy to discuss that as well when we sync.

thotasrinath commented 4 weeks ago

Thanks, I can connect through teams. Please send me an invite on Srinath.thota@outlook.com

Amar-C commented 3 weeks ago

@thotasrinath As the PR is merged can you help create a new release for it?

thotasrinath commented 3 weeks ago

Sure @Amar-C, Can help to update readme according to the changes please.

Amar-C commented 2 weeks ago

Sure @Amar-C, Can help to update readme according to the changes please.

Yup, Sharath updated the README. Could you please create a new tag? I can do it but not sure which CPU are you building the binary for?

thotasrinath commented 2 weeks ago

Please go ahead and create. I am at my home town with limited access.

Thanks, Srinath

From: Amar-C @.> Sent: Thursday, October 24, 2024 10:27:44 PM To: thotasrinath/xk6-couchbase @.> Cc: Srinath Thota @.>; Mention @.> Subject: Re: [thotasrinath/xk6-couchbase] Performance improvement by removing WaitUntilReady from individual operation (Issue #14)

Sure @Amar-Chttps://github.com/Amar-C, Can help to update readme according to the changes please.

Yup, Sharath updated the README. Could you please create a new tag? I can do it but not sure which CPU are you building the binary for?

— Reply to this email directly, view it on GitHubhttps://github.com/thotasrinath/xk6-couchbase/issues/14#issuecomment-2435793736, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABFRP6ICYN4BIILSG5ZE7J3Z5ERIRAVCNFSM6AAAAABNS74VS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVG44TGNZTGY. You are receiving this because you were mentioned.Message ID: @.***>

Amar-C commented 2 weeks ago

https://github.com/thotasrinath/xk6-couchbase/releases/tag/v0.0.9 should have the improvements