search

thoth-station / adviser

The recommendation engine for Python software stacks and Dependency Monkey in project Thoth.
https://thoth-station.github.io
GNU General Public License v3.0
34 stars 13 forks source link

[3pt]Provide a generic advise_manifest_changes in results that can be retrieved and used by thamos #2211

Open pacospace opened 2 years ago

pacospace commented 2 years ago

It might be good to provide a generic mechanism for this advised_manifest_changes so we can generalize the feature. Something like (rough design just to show the functionality):

advised_manifest_changes:
 - file: .thoth.yaml  # File that should be patched (can be also a buildconfig or so).
   patch:
     add: ...

Originally posted by @fridex in https://github.com/thoth-station/thamos/issues/910#issuecomment-942307322

Related-To: https://github.com/thoth-station/core/issues/308 Related-To: https://github.com/thoth-station/thamos/issues/910 Related-To: https://github.com/thoth-station/prescriptions-refresh-job/issues/87

goern commented 2 years ago

/kind bug /priority important-soon

pacospace commented 2 years ago

/kind bug /priority important-soon

It's actually a feature request :)

pacospace commented 2 years ago

hey @fridex do you want me to work on this?

fridex commented 2 years ago

hey @fridex do you want me to work on this?

Feel free to take it. It is not clear to me how a good integration should look like though (and if we should directly support something like this now).

mayaCostantini commented 2 years ago

/assign @mayaCostantini /sig stack-guidance /lifecycle active

mayaCostantini commented 2 years ago

/remove-lifecycle active

VannTen commented 2 years ago

/priority backlog