search

thoth-station / adviser

The recommendation engine for Python software stacks and Dependency Monkey in project Thoth.
https://thoth-station.github.io
GNU General Public License v3.0
34 stars 13 forks source link

flake8 checks in pre-commit fail #2335

Closed fridex closed 2 years ago

fridex commented 2 years ago

Bug description

tests/prescription/v1/test_group.py:37:28: F541 f-string is missing placeholders
tests/prescription/v1/test_group.py:185:28: F541 f-string is missing placeholders
tests/sieves/test_experimental_conf_index.py:150:21: F541 f-string is missing placeholders
tests/sieves/test_experimental_conf_index.py:168:21: F541 f-string is missing placeholders
thoth/adviser/resolver.py:1372:21: F541 f-string is missing placeholders
thoth/adviser/boots/environment_info.py:[92](https://prow.operate-first.cloud/view/s3/ci-prow/prow-logs/pr-logs/pull/thoth-station_adviser/2334/pre-commit/1524015462336172032#1:build-log.txt%3A92):32: F541 f-string is missing placeholders
thoth/adviser/boots/environment_info.py:99:32: F541 f-string is missing placeholders
tests/prescription/v1/test_add_package_step.py:219:28: F541 f-string is missing placeholders
tests/prescription/v1/test_add_package_step.py:316:28: F541 f-string is missing placeholders
tests/prescription/v1/test_add_package_step.py:416:28: F541 f-string is missing placeholders
tests/prescription/v1/test_add_package_step.py:516:28: F541 f-string is missing placeholders
tests/prescription/v1/test_add_package_step.py:617:28: F541 f-string is missing placeholders
tests/prescription/v1/test_add_package_step.py:719:28: F541 f-string is missing placeholders
tests/prescription/v1/test_gh_release_notes.py:311:28: F541 f-string is missing placeholders
thoth/adviser/prescription/v1/unit.py:5[99](https://prow.operate-first.cloud/view/s3/ci-prow/prow-logs/pr-logs/pull/thoth-station_adviser/2334/pre-commit/1524015462336172032#1:build-log.txt%3A99):25: F541 f-string is missing placeholders
thoth/adviser/boots/thoth_search.py:62:28: F541 f-string is missing placeholders
mayaCostantini commented 2 years ago

/sig stack-guidance /priority important-soon

VannTen commented 2 years ago

Is this still relevant ? does not seem to fail when I run it locally

VannTen commented 2 years ago

Fixed in #2341 /close

sesheta commented 2 years ago

@VannTen: Closing this issue.

In response to [this](https://github.com/thoth-station/adviser/issues/2335#issuecomment-1236932328): >Fixed in #2341 >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.